Use begin end/block instead of query in data commitments #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
liamsi,
evan-forbes and
Wondertan
as code owners
4 tasks
rach-id
commented
Aug 17, 2022
rach-id
changed the title
rach-id
commented
Aug 17, 2022
evan-forbes
approved these changes
Aug 17, 2022
rach-id
deleted the
use_begin_end_block_instead_of_query_in_data_commitments
branch
cmwaters
pushed a commit
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
querytobegin/endwhen creating a data root over a set of blocks.Closes #837 celestiaorg/celestia-app#604